Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing errors caught by the updated linter #3065

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Fixing errors caught by the updated linter #3065

merged 2 commits into from
Mar 18, 2019

Conversation

tombuildsstuff
Copy link
Contributor

Fixes:

44.35s$ make lint
==> Checking source code against linters...
golangci-lint run ./...
azurerm/data_source_notification_hub.go:115:42: nilness: impossible condition: nil != nil (govet)
		if d.Set("apns_credential", apns); err != nil {
		                                       ^
azurerm/data_source_notification_hub.go:120:40: nilness: impossible condition: nil != nil (govet)
		if d.Set("gcm_credential", gcm); err != nil {
		                                     ^
azurerm/encryption_settings.go:122:36: nilness: tautological condition: non-nil != nil (govet)
		if vault := key.SourceVault; key != nil {
		                                 ^
azurerm/resource_arm_application_gateway.go:1063:127: nilness: impossible condition: nil != nil (govet)
		if setErr := d.Set("waf_configuration", flattenApplicationGatewayWafConfig(props.WebApplicationFirewallConfiguration)); err != nil {
		                                                                                                                            ^
azurerm/resource_arm_application_gateway.go:2230:77: nilness: tautological condition: non-nil != nil (govet)
					if ruleProps := rule.ApplicationGatewayPathRulePropertiesFormat; props != nil {
					                                                                       ^
azurerm/resource_arm_key_vault_certificate.go:37:119: nilness: nil dereference in field selection (govet)
		return []*schema.ResourceData{d}, fmt.Errorf("Unable to locate the Resource ID for the Key Vault at URL %q: %s", id.KeyVaultBaseUrl, err)
		                                                                                                                    ^
azurerm/resource_arm_monitor_log_profile.go:257:11: nilness: tautological condition: non-nil != nil (govet)
	if input != nil {
	         ^
azurerm/resource_arm_notification_hub.go:257:42: nilness: impossible condition: nil != nil (govet)
		if d.Set("apns_credential", apns); err != nil {
		                                       ^
azurerm/resource_arm_notification_hub.go:262:40: nilness: impossible condition: nil != nil (govet)
		if d.Set("gcm_credential", gcm); err != nil {
		                                     ^
azurerm/resource_arm_role_assignment.go:173:61: nilness: tautological condition: non-nil != nil (govet)
			if roleProps := roleResp.RoleDefinitionProperties; props != nil {
			                                                         ^
azurerm/resource_arm_sql_database.go:565:9: nilness: impossible condition: nil != nil (govet)
	if err != nil {
	       ^
azurerm/resource_arm_virtual_machine.go:1914:64: nilness: tautological condition: non-nil != nil (govet)
					if pipProps := pip.PublicIPAddressPropertiesFormat; props != nil {
					                                                          ^
make: *** [lint] Error 1
The command "make lint" exited with 2.

@tombuildsstuff tombuildsstuff added this to the v1.24.0 milestone Mar 18, 2019
@ghost ghost added the size/S label Mar 18, 2019
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :shipit:

@tombuildsstuff tombuildsstuff merged commit 71d3687 into master Mar 18, 2019
@tombuildsstuff tombuildsstuff deleted the b/linting branch March 18, 2019 09:29
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants